Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeipa-ldap/freeipa-ldaps deprecated should use freeipa-4 #1005

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lessfoobar
Copy link

Copy link
Member

@rjeffman rjeffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supported on any version of firewalld? The roles must be supported, for example on CentOS 7.

Also, NTP port should also be supported, so something like (untested) {{ "--add-service=net" if ipaserver_no_ntp | default("True") | bool else "" }} to cope with NTP port which is not covered by service firewall-4.

And please, add a proper commit message explaining why the change is needed and what the change is about.

@rjeffman
Copy link
Member

BTW, thank you for the PR. This is a great catch!

@lessfoobar
Copy link
Author

@rjeffman somebody have already merged your suggestion thus I've fixed the freeipa-4 for runtime and permanent. Could you please review once more.

@lessfoobar lessfoobar requested a review from rjeffman March 8, 2023 22:31
@rjeffman rjeffman requested a review from t-woerner March 9, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants