-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve noble migration check script output #7369
Conversation
While working on the documentation PR (freedomofpress/securedrop-docs#612), I realized the output wasn't that great, so these are some minor changes to improve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Non-blocking nit: I would favor going all the way to (e.g.)—
ssh OK: group is empty
ssh ERROR: group is not empty [...]
—so that success as well as failure is explicit rather than implicit. But I defer to you.
That's a good idea, give me a minute :) |
* Explicitly flag which messages are error conditions; otherwise it would be hard to tell whether "group is empty" or "group is not empty" is the problematic state. * Do the same for success messages by adding "OK" to them. * Add a newline before our closing help message. * Link to docs that explain how to resolve these issues (still pending review at <freedomofpress/securedrop-docs#612>).
0038c95
to
4d77a7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely. Thanks, @legoktm.
Status
Ready for review
Description of Changes
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a
Checklist
make lint
) and tests (make test
) pass in the development container