Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions, license file, security.md #6

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Add github actions, license file, security.md #6

merged 4 commits into from
Dec 20, 2024

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Dec 6, 2024

Add github actions for lint and reprotest (see securedrop-workstation repo CI for reference, this is essentially a pared-down version), license, and security.md.

@rocodes rocodes requested a review from a team December 6, 2024 21:23
@rocodes rocodes mentioned this pull request Dec 6, 2024
4 tasks
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question regarding the poetry stuff; the rest looks good

pyproject.toml Outdated
authors = ["SecureDrop Team"]
license = "AGPLv3+"

[tool.poetry.dependencies]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no dependencies right now, do we need all the poetry infrastructure? Do you think we'll end up with Python dependencies in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Good point, given if we do any kind of graphical install assistance it will be in the workstation config app. poetry stuff is gone and the license and author are contained in the spec file, so I have removed pyproject.toml entirely; hopefully not rash.

pyproject.toml Outdated Show resolved Hide resolved
@rocodes rocodes requested a review from legoktm December 19, 2024 22:10
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legoktm legoktm merged commit 95f2cea into main Dec 20, 2024
4 checks passed
@legoktm legoktm deleted the add-ci branch December 20, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants