-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions, license file, security.md #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question regarding the poetry stuff; the rest looks good
pyproject.toml
Outdated
authors = ["SecureDrop Team"] | ||
license = "AGPLv3+" | ||
|
||
[tool.poetry.dependencies] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no dependencies right now, do we need all the poetry infrastructure? Do you think we'll end up with Python dependencies in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃 Good point, given if we do any kind of graphical install assistance it will be in the workstation config app. poetry stuff is gone and the license and author are contained in the spec file, so I have removed pyproject.toml entirely; hopefully not rash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add github actions for lint and reprotest (see securedrop-workstation repo CI for reference, this is essentially a pared-down version), license, and security.md.