Use sdconfig instead of manually editing the site-specific file in the OSSEC guide #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit minizes the use of manually editing the site-specific file, instead preferring the use of `securedrop-admin sdconfig` where applicable. As a result, this commit also restructures the flow of the OSSEC Guide, particularly during the sections related to installing SecureDrop.
eloquence
reviewed
May 21, 2024
eloquence
reviewed
May 21, 2024
eloquence
reviewed
May 22, 2024
eloquence
reviewed
May 22, 2024
eloquence
requested changes
May 22, 2024
eloquence
reviewed
May 22, 2024
|
Thanks for the review, @eloquence! I believe I was able to address all the suggestions, but please let me know if I need to tweak anything, or if you spot anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This PR minimizes the use of manually editing the
site-specificfile, instead preferring the use ofsecuredrop-admin sdconfigwhere applicable.As a result, this PR also restructures the flow of the OSSEC Guide, particularly during the sections related to installing SecureDrop.
site-specificmanually #556Testing
Checklist (Optional)
make docs-lint) passed locallymake docs-linkcheck) passedmake docs) docs at http://localhost:8000