Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI using GitHub Actions #452

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Run CI using GitHub Actions #452

merged 1 commit into from
Dec 8, 2023

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented May 26, 2023

Status

Ready for review

Description of Changes

Run CI using GitHub Actions

This is the exact same configuration currently used in the securedrop-dev-docs repository.

Refs freedomofpress/securedrop-tooling#5.

Testing

  • CI passes

@legoktm legoktm requested a review from cfm May 26, 2023 20:04
@legoktm
Copy link
Member Author

legoktm commented May 26, 2023

(will figure out why this is failing on Tuesday)

@legoktm legoktm force-pushed the gh-actions branch 3 times, most recently from 7dcfb5f to cdc02a2 Compare June 23, 2023 18:30
@leee leee force-pushed the gh-actions branch 2 times, most recently from b9176a0 to 37320c3 Compare December 8, 2023 18:33
Copy link
Member Author

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this up. Let's remove the CircleCI and set the build/pull_request and lint/pull_request jobs to be "Required" now. And then you can give this the green check and land it :)

leee
leee previously approved these changes Dec 8, 2023
Also:
- switch to podman from docker
- use HEAD instead of branch name

Refs <freedomofpress/securedrop-tooling#5>.

Co-authored-by: Kunal Mehta <[email protected]>
@legoktm legoktm merged commit 0f87fdf into main Dec 8, 2023
4 checks passed
@legoktm legoktm deleted the gh-actions branch December 8, 2023 19:09
@leee leee self-assigned this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants