Enable ruff's flake8-bugbear ruleset #2341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugbear was one of the most popular flake8 plugins and now ruff supports it. Running it found a number of missing "assert" statements, among other issues I all found valuable to fix: * Useless statements that were probably missing a leading "assert" * Mutable default arguments that should be constructed at function runtime * Unused loop variables that don't start with _ * Usage of str.strip() with a multi-character string I suppressed three types of errors: * Raising an exception inside an exception handler without using `from err`; would be nice to address later, but there were too many to assess. * Loop variables being bound past their lifetime; the two uses were only in tests and safe so I applied individual suppressions as we'd want to flag problematic uses in real code. * `pytest.raises(Exception)` is evil, but also not a priority to fix in tests.
legoktm
force-pushed
the
ruff-bugbear
branch
from
a761bfc to
d9c3a2b
Compare
|
The missing asserts have revealed that some tests were silently failing and will need some fixes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
bugbear was one of the most popular flake8 plugins and now ruff supports it. Running it found a number of missing "assert" statements, among other issues I all found valuable to fix:
I suppressed three types of errors:
from err; would be nice to address later, but there were too many to assess.pytest.raises(Exception)is evil, but also not a priority to fix in tests.Test Plan