-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for IPP / driverless printing #2332
base: main
Are you sure you want to change the base?
Conversation
Changes export logic (in sd-devices) to be able to detect IPP printers without breaking compatibility with the old system. To achive this, ipp-usb is used in combination with Avahi. The former detects IPP-compatible printers and creates a local IPP server. Avahi allows for the discovery of these printing servers such that print dialogs can display print information. Contrary to the legacy printer support, for driverless printing, no print queue is setup with `lpadmin`. Printers are automatically discovered.
0f81722
to
9e83012
Compare
b0a7a1a
to
d60947d
Compare
Necessary for GTK print dialog
Note: system-wide dependencies made available from securedrop-export venv due to the need to access python3-gi. Otherwise it would require too many build dependencies and complexity. Given that python3-gi is already required by some Qubes components, it does not add too many new dependencies.
d60947d
to
078a14e
Compare
Progress updateI have now added the GTK dialog itself. As you can see it gets information from the printer before it shows the options. It's a bit of downside of driverless printing when the printer was not previously added. The user has to wait a tiny bit until the printer configurations are obtained. There are ways around that (i.e. adding a print queue), but that requires state, which we're avoiding in disposables. (we decided that here) Next stepsI have updated the |
@legoktm regarding the following comment: securedrop-client/export/pyproject.toml Lines 14 to 21 in bdf52bc
How critical is is that we keep this in sync? Should some sort of CI warning to update this when the debian packages have been updated? How is it handled for Qt in securedrop-client? Also, do we need it in the root |
Relatively important, mostly so that our local operation and tests are using the same version that the package is. Realistically the version should only change when we switch Debian versions (e.g. bookworm -> trixie), so we can handle it then. It would be pretty rare for a version bump to come out once a version has already been made stable.
No, just in export's. The only things in the root pyproject.toml should be the various CI tools we run across the whole project. |
Changes export logic (in sd-devices) to be able to detect IPP printers without breaking compatibility with the old system.
To achieve this, ipp-usb is used in combination with Avahi. The former detects IPP-compatible printers and creates a local IPP server. Avahi allows for the discovery of these printing servers such that print dialogs can display print information.
Contrary to the legacy printer support, for driverless printing, no print queue is setup with
lpadmin
. Printers are automatically discovered.Status
Work in progress
Description
Fixes #2088 #2156.
TODO:
avahi
enabled (preset as enabled is not cutting it)(and get(used system packages in venv instead)PyGObject
wheels to build)Test Plan
cups
andavahi
tosd-devices
Qubes servicesChecklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
main
and confirmed that the migration is self-contained and applies cleanlymain
and would like the reviewer to do so