Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide ReplyTextEdit when deletion of conversation in progress #1306

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

sssoleileraaa
Copy link
Contributor

Description

Fixes #1286

As followup, instead of hiding text in the replybox when a conversation is being deleted, we can show the text as disabled. We can continue conversation about this as needed here: #1303

Test Plan

  1. using the venv-debian virtual environment, run the client (or package the client from this PR branch and install it in sd-app)
  2. apply this diff to make testing easier: https://gist.github.com/creviera/8ed991737752a35785033ceac903d878
  3. delete all files and messages for a source
  • confirm bug is fixed both visually and functionally:
    • the replybox does not show a white textarea
    • you cannot type into the replybox and send replies during the deletion operation

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@sssoleileraaa sssoleileraaa requested a review from a team as a code owner September 29, 2021 20:45
@sssoleileraaa sssoleileraaa changed the title hide ReplyTextEdit when cdeletion in progress hide ReplyTextEdit when deletion of conversation in progress Sep 29, 2021
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! To test, I built a new package from this branch and installed in sd-app. (I included the recommended time.sleep, as well, to make testing a bit easier.) The improvement here is obvious, the textbox is not available for interaction while the pending dialog is shown.

While testing, I also observed #1285, but will comment on that thread separately—not blocking merge since we've got that behavior tracked elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reply box styled incorrectly and partially enabled during deletion
2 participants