Reply box styled incorrectly and partially enabled during deletion

[eloquence]

The reply box styling does not match the prototypes while a deletion is underway; in both deletion interaction flows, it looks like the reply box is enabled (but sitting on a grayed out background). After clicking repeatedly, I can sometimes type into the reply box.

Steps to reproduce

1. Delete a source (files and messages or source account)

Expected behavior

Styling of reply placeholder matches prototypes

Actual behavior

Illustrated below, note how I can type into the reply box while a deletion operation is underway.

[conorsch]

Tried reproducing this while reviewing #1301, and it's tricky (but possible) to do so in the dev env. Will try again with a staging env, so the tor connection is in play, and the round-trip provides sufficient time to reproduce the graphical quirk.

[conorsch]

In a staging environment, with connections going over Tor, I certainly had more time to attempt reproduction, but still struggled. Here's a video of my failing to reproduce the issue (the reply box does not accept clicking during deletion, but does after):

The fact that I couldn't easily reproduce it doesn't mean it's not a bug, I'll certainly keep trying. One problem I was able to see is that the message pane showed the to-be-deleted messages and attachments during the deletion pending operation, then updated to correctly show no messages after completion:

Adding this info simply as more corroboration that the flow isn't quite what we want, will continue to test.

[conorsch]

@creviera mentioned she has a potential fix for this problem, so I'm standing by to review the diff. In the meantime, I'll investigate #1290.

[ninavizz]

Actually, the way it shows in @conorsch's video, is troubling. It's not literally reproducing, but the Reply box still stands-out as white, surrounded by an off-white frame. That is not right.

[eloquence]

You're looking at an old video Nina, before the PR with the fix was merged.

[ninavizz]

@eloquence Yes, of course. Was what conor did observe part of the problem that was fixed?

Also, I'd like to request some slight changes to the Star Wars acceleration pattern at the end of Conor's videos. Those are a great start, but Han Solo needs really to emerge through the user's monitor to bring the whole experience together.

[eloquence]

Yes, that was fixed. By my eye the deletion panel looks closer to the prototype now; I'm noticing two discrepancies which we may want to track as follow-up polish issues (but which IMO can wait until after the release, given the higher priority issues on the milestone):

• The "Compose a reply" placeholder text is removed rather than styled disabled
• The "Send" icon is styled grey instead of in a subdued version of its original color

Here's a screenshot - please don't hesitate to poke at the nightly build & point out any issues you see and/or open new ones. Thank you as always for your attention to detail!

[sssoleileraaa]

Related issue about not deleting the draft reply in the "Compose a reply" textbox: #1303