Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proxy wheels, no longer used #499

Merged
merged 1 commit into from
May 30, 2024
Merged

Remove proxy wheels, no longer used #499

merged 1 commit into from
May 30, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented May 24, 2024 •
edited by cfm
Loading

Status

Ready for review

Description

As of proxy v2, it's now implemented in Rust so there is no need for these Python wheels anymore.

Test plan

  • Visual review
  • CI passes

@legoktm
Remove proxy wheels, no longer used
f4a33f7 
As of proxy v2, it's now implemented in Rust so there is no need
for these Python wheels anymore.
cfm
cfm approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, @legoktm. I note for the record that this also removes checking the reproducibility of securedrop-proxy's wheels.

@cfm cfm added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 581e5b1 May 30, 2024
6 checks passed
@cfm cfm deleted the proxyv2 branch May 30, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfm cfm cfm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legoktm @cfm