-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests to GitHub Actions #496
Conversation
58aefa8
to
1eaa3ea
Compare
This is ready for review, but does not include On the other hand, the CircleCI config appears to be borked on this repo -- CircleCI is complaining about lack of SSH checkout key. I defer to the SD team if that's worth fixing before we've got the job switched over. If not, I can poke more at it Monday/Tuesday to finish things up. |
Re: reprotest, I do see a lot of |
49e9a7e
to
2558a16
Compare
This PR is also removing the CircleCI config, so CircleCI is complaining now, but if the rest of it looks good, we can remove the CircleCI config fully from this repo prior to merge. |
name: install test requirements and run tests | ||
command: | | ||
adduser --system ci --ingroup root | ||
sed -i -re "292s/^(\s+).*\$/\1return _.prepend_to_build_command_raw('')/" /usr/lib/python3/dist-packages/reprotest/build.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This in-place patching goes back to 18770bd and, if it was still relevant at all, was not necessary for the wheel reproducibility checks, which do not use the reprotest
package that is being patched here. The actual Debian reproducibility check has been migrated into securedrop-client
and no longer uses reprotest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM! We will want to move these jobs to bookworm ASAP now (c.f. freedomofpress/securedrop-client#1958) but we can do that in a separate PR. Will poke infra for the CircleCI disconnect.
2558a16
to
fe5e74c
Compare
fe5e74c
to
85e05a8
Compare
Migrates
make test
andmake reprotest
tests to GitHub Actions and removes the CircleCI configuration.Fixes #482.
Test plan