Add ruff for lint & formatting checks; apply some suggested fixes #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GitHub action that runs format & lint checks.
Draws from freedomofpress/securedrop#6961 for the ruff config.
I've implemented several of the linter suggestions while ignoring others.
This PR also applies
ruff
's code formatting (which in turn is a drop-in replacement forblack
).ruff
appears to be a bit less aggressive thanblack
in enforcing line length, so we have to disable the line length check itself.NB: Our undocumented use of
test-requirements.txt
is another potential candidate for Poetry; I've saved this for a follow-up change.Fixes #463
Testing
test-requirements.txt
in a venv and verify that Makefile targets work as expected