dev_scripts: Upload release assets to GitHub #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apyrgio
force-pushed
the
2023-12-upload-assets
branch
from
cff9093 to
44f1c52
Compare
deeplow
reviewed
Dec 14, 2023
There was a problem hiding this comment.
This will be super useful. I'm just thinking of how we can simplify the interface of this script. Most likely we'll use it infrequently enough that we won't remember how to operate it (and it may no longer be in the bash_history).
So it would be nice if we could use as intuitively as ./dev_scripts/upload-asset.py <asset>. To make this possible I have a few suggestions:
- uploading by default to the latest draft release by default. If failed, asking the user to create first a draft release
- asking for the token if not provided via
--tokenalong with instructions on how to get it. If I'm not mistaken, this token can have at most 1 year, so we'll need to renew it every 4-5 uses of the script.
|
Those are very good suggestions. I pushed a fixup commit (9cc346a) that should address them. |
deeplow
approved these changes
Dec 18, 2023
Add a script to upload release assets to GitHub. This script can take either a release ID, a Git tag, or the latest draft release. Note that while GitHub's official client can upload assets to releases, it cannot upload them to draft releases [1], hence why we created this script. [1]: https://cli.github.com/manual/gh_release_upload
Add missing git dependency, which is required to run the `isort` command on the development environment.
apyrgio
force-pushed
the
2023-12-upload-assets
branch
from
4e0c0ca to
12eda5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a script to upload release assets to GitHub. This script can take either a release ID, a Git tag, or the latest draft release.
Note that while GitHub's official client can upload assets to releases, it cannot upload them to draft releases 1, hence why we created this script.