Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pkg repo file hash ability to poudriere.conf Default to off #786

Closed
wants to merge 1 commit into from

Conversation

darkfiberiru
Copy link

@allanjude Here's an initial addition to poudriere. Do you think it makes sense to expose both hash and symlink ability or just default to creating symlink if your appending hash to package name

If anyone has a prefered method to a poudriere.conf variable Please let me know

@allanjude Also any help on wording for poudriere.conf comment would be appreciated

@swills
Copy link
Member

swills commented Sep 14, 2020

Is it me or is there a mix-up between $PKG_OPTIONS and $REPO_OPTIONS here? Looks like $PKG_OPTIONS is set and not used and $REPO_OPTIONS is used but not set.

src/etc/poudriere.conf.sample Outdated Show resolved Hide resolved
Copy link
Author

@darkfiberiru darkfiberiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swills Thank you indecisiveness striked on variable naming and I didn't proofread well enough. Fixed now along with improvements to pourdriere.conf option comment. @dch Thanks for input. Does the new wording read any better.

src/etc/poudriere.conf.sample Outdated Show resolved Hide resolved
@darkfiberiru
Copy link
Author

#751 Apparently this is a duplicate as I didn't search prior june when the pkg hash work was redone and allan had submitted a PR in april

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants