Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

feat(tools): add visability of auth0 rules #108

Merged
merged 2 commits into from
May 4, 2018
Merged

feat(tools): add visability of auth0 rules #108

merged 2 commits into from
May 4, 2018

Conversation

Bouncey
Copy link
Member

@Bouncey Bouncey commented May 3, 2018

In looking into the accountLinkId issue described in #107, I found it was as simple as adding uuid() inside the rule

@Bouncey Bouncey mentioned this pull request May 3, 2018
Open
@raisedadead
Copy link
Member

raisedadead commented May 3, 2018 •
edited
Loading

Quick query are you using the webtask integration (natively provided by auth0) for this? We can move this to "Auth0 Management API + Lambda" in future for more complex actions.

raisedadead
raisedadead reviewed May 3, 2018
View reviewed changes
auth0-rules/add-accountLinkId-to-token.js Outdated
*/

function addAccountLinkId(user, context, callback) {
const namespace = 'https://www.freecodecamp.org/accountLinkId';

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@Bouncey
Copy link
Member Author

Bouncey commented May 3, 2018

Whilst trying to access the app_metadat from the token, I stumbled across this comment which lead me to this rule

ojongerius
ojongerius reviewed May 4, 2018
View reviewed changes
src/auth/index.js
@@ -8,7 +8,7 @@ const { JWT_CERT } = process.env;

export { updateAppMetaData } from './auth0';

export const namespace = 'https://www.freecodecamp.org/';
export const namespace = 'https://auth-ns.freecodecamp.org/';

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@raisedadead raisedadead merged commit 222fd18 into freeCodeCamp:staging May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ojongerius ojongerius ojongerius left review comments

@raisedadead raisedadead raisedadead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bouncey @raisedadead @ojongerius