-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: creating a colors.css file to manage reusable styles #1243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a first pass and left some review comments 👍
i tested the pr at my machine - the way it runs looks good to me... |
hey @shootermv glad to hear so what are the next steps now |
We need someone who owns this repo - to merge the changes |
who is the owner of this repo? |
People of fcc stuff has merge permissions
…On Tue, Dec 3, 2024, 17:28 Siddhant Bansal ***@***.***> wrote:
who is the owner of this repo?
—
Reply to this email directly, view it on GitHub
<#1243 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKGMHVAUWSWOLP4GIVT5S32DXE2TAVCNFSM6AAAAABS2YDXJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJUHA4DGMJZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@shootermv thanks for the info , so what should i do ,should i contact them? |
Don't worry they will take care of the pr. It can take some time, but they
see
…On Tue, Dec 3, 2024, 17:39 Siddhant Bansal ***@***.***> wrote:
@shootermv <https://github.com/shootermv> thanks for the info , so what
should i do ,should i contact them?
—
Reply to this email directly, view it on GitHub
<#1243 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKGMHTR4DHELPRMDGFH3YT2DXGDJAVCNFSM6AAAAABS2YDXJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJUHEYTANRQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍
Summary of changes
Checklist
closes #1215