Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: creating a colors.css file to manage reusable styles #1243

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

Bugbuster2004
Copy link
Contributor

Summary of changes

  1. inside the stylesheets folder i have made colors.css file
  2. inside the colors.css file i made the css variable colors based on the websites color scheme used
  3. imported colors.css file in all the existing css files and replaced the hardcoded values with variable colors
  4. tried and tested the working using pnpm start on the local host and is working fine as of now.

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

closes #1215

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a first pass and left some review comments 👍

src/stylesheets/colors.css Outdated Show resolved Hide resolved
src/stylesheets/colors.css Outdated Show resolved Hide resolved
src/stylesheets/App.css Outdated Show resolved Hide resolved
@jdwilkin4 jdwilkin4 changed the title Issue-1215 made a colors.css file and made all the variables name that are required according to the website color scheme chore: creating a colors.css file to manage reusable styles Dec 2, 2024
@shootermv
Copy link
Contributor

i tested the pr at my machine - the way it runs looks good to me...

@Bugbuster2004
Copy link
Contributor Author

hey @shootermv glad to hear so what are the next steps now

@shootermv
Copy link
Contributor

shootermv commented Dec 3, 2024

We need someone who owns this repo - to merge the changes

@Bugbuster2004
Copy link
Contributor Author

Bugbuster2004 commented Dec 3, 2024

who is the owner of this repo?
@jdwilkin4 any ideas regarding the owner of this repo so that we can connect

@shootermv
Copy link
Contributor

shootermv commented Dec 3, 2024 via email

@Bugbuster2004
Copy link
Contributor Author

@shootermv thanks for the info , so what should i do ,should i contact them?

@shootermv
Copy link
Contributor

shootermv commented Dec 3, 2024 via email

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit cdc1fba into freeCodeCamp:main Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[imporvement] - move colors css rules to colors.css file
3 participants