Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imporvement] - move colors css rules to colors.css file #1215

Closed
shootermv opened this issue Nov 4, 2024 · 3 comments · Fixed by #1243
Closed

[imporvement] - move colors css rules to colors.css file #1215

shootermv opened this issue Nov 4, 2024 · 3 comments · Fixed by #1243
Labels
help wanted Extra attention is needed

Comments

@shootermv
Copy link
Contributor

shootermv commented Nov 4, 2024

What bug did you find in the codebase?

it can be good to have all colors css rules like backgrounds, border colors, text colors, etc - to be at separate colors.css file.
Also it can be good to define the color values as css variables
like: --primary: #0a0a23

@shootermv shootermv added the bug Something isn't working label Nov 4, 2024
@shootermv shootermv changed the title [Bug] - move colors css rules to colors.css file [imporvement] - move colors css rules to colors.css file Nov 5, 2024
@jdwilkin4 jdwilkin4 added help wanted Extra attention is needed and removed bug Something isn't working labels Nov 12, 2024
@Bugbuster2004
Copy link
Contributor

hey @shootermv i wanted to work on this issue, i find it interesting

@shootermv
Copy link
Contributor Author

Go ahead! Feel free to work on it

@Bugbuster2004
Copy link
Contributor

Bugbuster2004 commented Dec 2, 2024

hey @shootermv i have made the desired changes just wanted to ask that in which branch should i send the PR in the main or any other branch?
Well according to the guidelines ig its the main branch only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants