Set the loop points in juce::AudioPlayHead::PositionInfo #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper wasn't setting the loop
ppqStart
andppqEnd
ofjuce::AudioPlayHead::PositionInfo::LoopPoints
that can be accessed viagetPlayHead()->getPosition()->getLoopPoints()
, this proved to be an issue in one of my plugins.There maybe an argument that within this code (that immediately follows my addition):
perhaps could try and set these loop point by converting seconds to PPQ iff they hadn't already been set by the preceding code, but I think it's a very tenuous argument and it's likely an extremely niche edge case scenario that wouldn't be able to set the loop points by beats anyway and not worth covering.
Proposed change fixes my issue.