Skip to content

Commit

Permalink
replace allow_errors with continue_on_error
Browse files Browse the repository at this point in the history
  • Loading branch information
tpapp committed Oct 15, 2024
1 parent 5a5581a commit 8a8859e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
20 changes: 10 additions & 10 deletions src/Literate.jl
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ function create_configuration(inputfile; user_config, user_kwargs, type=nothing)
cfg["softscope"] = type === (:nb) ? true : false # on for Jupyter notebooks
cfg["keep_comments"] = false
cfg["execute"] = type === :md ? false : true
cfg["allow_errors"] = false
cfg["continue_on_error"] = false
cfg["codefence"] = pick_codefence(
get(user_config, "flavor", cfg["flavor"]),
get(user_config, "execute", cfg["execute"]),
Expand Down Expand Up @@ -434,7 +434,7 @@ Available options:
output script. Only applicable for `Literate.script`.
- `execute` (default: `true` for notebook, `false` for markdown): Whether to execute and
capture the output. Only applicable for `Literate.notebook` and `Literate.markdown`.
- `allow_errors` (default: `false`): Whether to capture and display error messages. If
- `continue_on_error` (default: `false`): Whether to capture and display error messages. If
`true`, blocks that error will display the error message. If `false`, errors will be
(re)thrown as is. Ignored when `execute == false`.
- `codefence` (default: `````"````@example \$(name)" => "````"````` for `DocumenterFlavor()`
Expand Down Expand Up @@ -625,7 +625,7 @@ function markdown(inputfile, outputdir=pwd(); config::AbstractDict=Dict(), kwarg
image_formats=config["image_formats"],
file_prefix="$(config["name"])-$(chunknum)",
softscope=config["softscope"],
allow_errors=config["allow_errors"],
continue_on_error=config["continue_on_error"],
)
end
end
Expand All @@ -644,10 +644,10 @@ end
function execute_markdown!(io::IO, sb::Module, block::String, outputdir;
inputfile::String, fake_source::String,
flavor::AbstractFlavor, image_formats::Vector, file_prefix::String,
softscope::Bool, allow_errors::Bool)
softscope::Bool, continue_on_error::Bool)
# TODO: Deal with explicit display(...) calls
r, str, _ = execute_block(sb, block; inputfile=inputfile, fake_source=fake_source,
softscope=softscope, allow_errors=allow_errors)
softscope=softscope, continue_on_error=continue_on_error)
# issue #101: consecutive codefenced blocks need newline
# issue #144: quadruple backticks allow for triple backticks in the output
plain_fence = "\n````\n" => "\n````"
Expand Down Expand Up @@ -784,7 +784,7 @@ function jupyter_notebook(chunks, config)
nb = execute_notebook(nb; inputfile=config["literate_inputfile"],
fake_source=config["literate_outputfile"],
softscope=config["softscope"],
allow_errors=config["allow_errors"],
continue_on_error=config["continue_on_error"],
)
end
catch err
Expand All @@ -797,7 +797,7 @@ function jupyter_notebook(chunks, config)
end

function execute_notebook(nb; inputfile::String, fake_source::String, softscope::Bool,
allow_errors=allow_errors)
continue_on_error=continue_on_error)
sb = sandbox()
execution_count = 0
for cell in nb["cells"]
Expand All @@ -807,7 +807,7 @@ function execute_notebook(nb; inputfile::String, fake_source::String, softscope:
block = join(cell["source"])
r, str, display_dicts = execute_block(sb, block; inputfile=inputfile,
fake_source=fake_source, softscope=softscope,
allow_errors=allow_errors)
continue_on_error=continue_on_error)

# str should go into stream
if !isempty(str)
Expand Down Expand Up @@ -890,7 +890,7 @@ end

# Execute a code-block in a module and capture stdout/stderr and the result
function execute_block(sb::Module, block::String; inputfile::String, fake_source::String,
softscope::Bool, allow_errors::Bool)
softscope::Bool, continue_on_error::Bool)
@debug """execute_block($sb, block)
```
$(block)
Expand All @@ -916,7 +916,7 @@ function execute_block(sb::Module, block::String; inputfile::String, fake_source
end
end
popdisplay(disp) # IOCapture.capture has a try-catch so should always end up here
if c.error && !allow_errors
if c.error && !continue_on_error
error("""
$(sprint(showerror, c.value))
when executing the following code block from inputfile `$(Base.contractuser(inputfile))`
Expand Down
4 changes: 2 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1459,7 +1459,7 @@ end end
end # mktempdir
end end

@testset "allow_errors=true" begin
@testset "continue_on_error=true" begin
input_with_error =
"""
# The following will error
Expand All @@ -1469,7 +1469,7 @@ end end
mktempdir(@__DIR__) do sandbox
inputfile = joinpath(sandbox, "input.jl")
write(inputfile, input_with_error)
Literate.markdown(inputfile, sandbox; allow_errors = true, execute = true)
Literate.markdown(inputfile, sandbox; continue_on_error = true, execute = true)
output_md = read(joinpath(sandbox, "input.md"), String)
@test occursin("DomainError(-1.0", output_md)
end
Expand Down

0 comments on commit 8a8859e

Please sign in to comment.