Stop serving client that is already gone #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...at least for potentially long lasting actions, e.g. /D or /K24. This avoids unnecessarily blocking bsb-lan for other tasks (including new client requests).
not perfect, but at least loops are quit, thus definitely shortening unnecessary bsb-lan blocking
|
P.s. now also addressing /QD handling. (Tested on my system.) |
|
Great idea, thanks! Does this also mean that you can abort let's say a long query of parameters (such as /0-9999) by hitting the "Stop" button on the browser and start a new query right after? Because that has often confused users who were wondering why BSB-LAN was still not responding for minutes until the query in the background was completed. |
|
Yes, tested right now. :) |
|
Btw, I've done my testing by calling the url commands that usually take a long time, then immediately going back to the previous page in the browser (alt + left), which cancels the client connection and creates a new one. |
|
Great, that's really helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...at least for potentially long lasting actions, e.g. /D or /K24.
This avoids unnecessarily blocking bsb-lan for other tasks (including new client requests).
Succesfully tested on ESP32 with wifi connection, using the url commands given above.
I consider this ready for merging.