Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set preferred email in Employee via backend controller #45320

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gavindsouza
Copy link
Collaborator

Noticed when Employee was bulk updated from list view for prefered_contact_email to "Company Email" did not set the appropriate values under preferred_email because the respective code was in the desk script 😄

Set "Preferred Email" for Employee via validate based on "Preferred Contact Email" value which can be either "Company Email", "Personal Email" or "User ID".

Additional change to note: Unset preferred_email when prefered_contact_email is also unset.

Set "Preferred Email" for Employee via validate. Unset value when
prefered_contact_email is also unset.
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 17, 2025
@gavindsouza gavindsouza removed the needs-tests This PR needs automated unit-tests. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant