-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mitch master #1
Open
mwand
wants to merge
24
commits into
master
Choose a base branch
from
mitch-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mitch master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Frank's builder code to mitch-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my version of abstractfactory.
Look at the text I wrote at the top of index.ts and explodingroom.ts . You may find that helpful.
In explodingroom.ts, I added a second implementation of the factory: one built "from scratch", and one built by inheritance. I put some explanation about the relationship between AbstractFactory and the use of inheritance to build new factories. See if you like it.
I was unable to standardize on "export default" because (a) I couldn't figure out the syntax for exporting more than one value from a file and (b) when I tried to export an interface, TS complained that it was not possible to export a type.
I also got a nasty type error which turned out to be because I was importing one thing from a file, and the default export was something else.
So the code standardizes on locally declaring exports, and then importing
import {Foo, Bar} from './whatever'
I suspect that the True TypeScript way is to say
import * as what from './whatever/
and then writing
what.Foo and what.Bar
But I don't assert that with much confidence.
Enjoy!
--Mitch