Merge upstream improvements #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be added to all newrelic log messages. * The ADDITIONAL_ATTRIBUTES environment variable value is a json encoded map(string,string). Defaults to empty map.
… not valid JSON * Decode Additional attributes at init instead of during the payload creation (Fail fast)
…pressed payload<1MB) for large file
…PATTERN, S3_IGNORE_PATTERN env variables BATCH_SIZE_FACTOR: affects uncompressed batch size, default: 1.5 S3_CLOUDTRAIL_LOG_PATTERN: regex pattern to match CloudTrail log file, default: .*CloudTrail.*\.json.gz$ S3_IGNORE_PATTERN: regex pattern to match log file to be ignored/skipped, default: $^
…ar BATCH_SIZE_FACTOR
Incremented version to 1.1.2
Increment version to 1.1.2
This is needed so SAM takes care of the dependency management when packaging
Fix structure for SAM and update version in the template
…ines Adding developer docs and makefile
Added PermissionsBoundary and FunctionRole optional parameters
* Update README.md Updated to Community Plus header * Fix typo docume to document Co-authored-by: Daniel Rodríguez <[email protected]>
Co-authored-by: Daniel Rodríguez <[email protected]>
* Upgrade dependencies versions because vulnerability issues * Version bump to v1.1.4
Allow adding additional attributes
feat: bump Python runtime version to v3.11
…_fix Fix for library vulnerabilities
…issue_fix Issue with CloudTrail digest fixed
…ents_path_fix Fix python requirements file path in serverless configuration
…es_fix Fix for vulnerable libraries
This is needed so `sam build` can actually install the dependencies. See also newrelic/aws_s3_log_ingestion_lambda#eee8ddb
The new `ADDITIONAL_ATTRIBUTES` provides a full replacement, so the logic now is to use what is configured in that variable, and only if that is unset fall back to parsing `NR_TAGS` and `NR_ENV_DELIMITER`. Note that `ADDITIONAL_ATTRIBUTES` is a JSON string, and doesn't contain the logic to not add `aws:`- and `plugin:`-prefixed properties: If those aren't wanted they shouldn't be provided.
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the improvements from upstream into our own fork.
Note that this retains the existing build infrastructure (in FramerInfrastructureFunctions), even though there is now an easier logic available here with
sam build --use-container NewRelicLogIngestion. Adapting this will happen in another step.See also https://github.com/framer/company/issues/26513