Skip to content

Commit

Permalink
Drop unminimize action from utils
Browse files Browse the repository at this point in the history
  • Loading branch information
Francesco Maria Cultrera committed Oct 4, 2023
1 parent 6cecfad commit d9eb1c1
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/utils/NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

## OS Support

This Feature should work on recent versions of Ubuntu-based distributions.
This Feature should work on recent versions of Debian/Ubuntu-based distributions.
7 changes: 1 addition & 6 deletions src/utils/devcontainer-feature.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,8 @@
"version": "0.0.1",
"name": "Utilities",
"documentationURL": "https://github.com/framctr/devcontainer-features/tree/main/src/utils",
"description": "Install an up-to-date version of various utilities and unminimize the Ubuntu image.",
"description": "Install an up-to-date version of various utilities.",
"options": {
"unminimize": {
"type": "boolean",
"default": true,
"description": "Unminimize the Ubuntu image. Useful if you want to get a complete Ubuntu devenvironment with, for example, the man binary."
},
"ping": {
"type": "boolean",
"default": true,
Expand Down
11 changes: 0 additions & 11 deletions src/utils/install.sh
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@
#!/bin/sh
set -e

. /etc/os-release

if [ "${UNMINIMIZE}" = "true" ] ; then
if [ "${ID}" != "ubuntu" ] ; then
echo "Unminimize works only on ubuntu! Found ${ID}."
exit 1
fi

apt update && apt upgrade -y && (echo y | unminimize)
fi

utils=""

if [ "${PING}" = "true" ] ; then
Expand Down
1 change: 0 additions & 1 deletion test/utils/check_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ set -e
# Provides the 'check' and 'reportResults' commands.
source dev-container-features-test-lib

check "execute command" bash -c "man --version"
check "execute command" bash -c "ping -V"
check "execute command" bash -c "ipcalc --version"
check "execute command" bash -c "curl --version"
Expand Down
1 change: 0 additions & 1 deletion test/utils/scenarios.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"features": {
"utils": {
"unminimize": true,
"ping": true,
"ipcalc": true,
"curl": true,
Expand Down

0 comments on commit d9eb1c1

Please sign in to comment.