Enable changes related to frozen strings #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torrocus
force-pushed
the
al-frozen-string-literal
branch
from
887983b to
0371df9
Compare
I decided to use Rubocop autocorrect to enable frozen string literal
in our files.
> Style/FrozenStringLiteralComment:
> Missing frozen string literal comment.
> Layout/EmptyLineAfterMagicComment:
> Add an empty line after magic comments.
> Style/RedundantFreeze:
> Do not freeze immutable objects, as freezing them has no effect.
Also, I disabled `Style/RedundantFetchBlock`
because it conflicted with another linter.
> Style/RedundantFetchBlock:
> Use fetch(..., ...) instead of fetch(...) { ... }.
There are a lot of changed files, but these changes are repeatable
and should not affect the behavior of the application.
torrocus
force-pushed
the
al-frozen-string-literal
branch
from
0371df9 to
69784c8
Compare
ania-hm
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
I decided to use Rubocop autocorrect to enable frozen string literal in our files.
Also, I disabled
Style/RedundantFetchBlockbecause it conflicted with another linter.There are a lot of changed files, but these changes are repeatable and should not affect the behavior of the application.
Feedback
N/A
UI Changes
N/A