Fix accordions behavior #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap accordion stops working [1] if `data-bs-toggle` contains a name with a dot. Our project slug names contain dots. However, we don't need to use a slug here. We have a unique index at our disposal. Changing data-bs-toggle and id restores accordion functionality. [1]: https://getbootstrap.com/docs/5.3/components/accordion/
I added these two tests to clearly show that the Project model will be validable with slugs both without and with dots.
noplisu
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Recently we have noticed that some accordions are not behaving correctly. @ania-hm discovered that what makes them stand out is that their slug name of projects contain a dot. This allowed us to understand the cause of the problem. Adding a dot to the name meant that
data-bs-targetandidprobably didn't match. We changed our views a bit because a slug containing a dot is valid.Feedback
N/A
UI Changes
N/A