Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zeitwerk on CI #404

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Fix Zeitwerk on CI #404

merged 3 commits into from
Nov 3, 2023

Conversation

torrocus
Copy link
Member

@torrocus torrocus commented Nov 3, 2023

Pull Request Summary

The Zeitwerk job was not working properly. This PR fixes the problem. The system package was missing.

Feedback

Screenshot from 2023-11-03 09-44-46

UI Changes

N/A

@torrocus torrocus added the ci Continuous Integration label Nov 3, 2023
@torrocus torrocus requested a review from ania-hm November 3, 2023 08:46
Running Zeitwerk check on CI failed and we saw in the logs:

> Run bundle exec rails zeitwerk:check
> Hold on, I am eager loading the application.
> rails aborted!
>
> LoadError: Could not open library 'vips.so.42':
> vips.so.42: cannot open shared object file:
> No such file or directory. (LoadError)
>
> Could not open library 'libvips.so.42':
> libvips.so.42: cannot open shared object file:
> No such file or directory.
>
> Searched in <system library path>, /usr/lib, /usr/local/lib,
> /opt/local/lib
...
> Error: Process completed with exit code 1.

Since we have our dev environment prepared locally,
we were not aware of the problem until we launched the workflow on CI.

Installing the appropriate vips library should help.

In the future, we may think about a way to cache system packages. [1]

[1]: https://github.com/awalsh128/cache-apt-pkgs-action
For now, we have only started this workflow manually.
We know it works properly, so we can run it with each new PR.
@torrocus torrocus force-pushed the al-fix-zeitwerk-on-ci branch from 6ae7704 to d2ae36b Compare November 3, 2023 08:52
@torrocus torrocus merged commit bbb9b59 into main Nov 3, 2023
11 checks passed
@torrocus torrocus deleted the al-fix-zeitwerk-on-ci branch November 3, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants