Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second attempt to fix issue #30: Classifier widget restarts #46

Merged
merged 8 commits into from
Jul 19, 2024

Conversation

jluethi
Copy link
Collaborator

@jluethi jluethi commented Jul 19, 2024

@jluethi
Copy link
Collaborator Author

jluethi commented Jul 19, 2024

The issue with #30 was having existing Annotation & Prediction layers. I now ensure that they get removed when using Load Classifier. Now that workflow appears to work robustly.

I noticed another issue in the Load Classifier flow though: The keybindings for e.g. switching classes stop working. The necessary section of code is run with the correct parameters as far as I can tell. Don't know why does keybindings aren't working in that section anymore.

@jluethi
Copy link
Collaborator Author

jluethi commented Jul 19, 2024

Also, I needed to pin numpy < 2 because of different test failures otherwise. Some related to np.string_ usage, others that I can't make sense of

@jluethi jluethi mentioned this pull request Jul 19, 2024
@jluethi jluethi marked this pull request as ready for review July 19, 2024 17:45
@jluethi
Copy link
Collaborator Author

jluethi commented Jul 19, 2024

This PR now fixes a few things:

  1. Handles translation in the layers correctly (also during annotation)
  2. Improve behavior upon Load Classifier: It shouldn't be required anymore to restart napari in regular workflows
  3. Right-click an annotation to remove it

@jluethi jluethi merged commit 69a1524 into main Jul 19, 2024
7 checks passed
@jluethi jluethi deleted the 30_closing_issue branch July 19, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant