Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Radiobuttons to select filter for FileEdit #37

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

fdsteffen
Copy link
Contributor

Addresses #36 to set a file filter for the FileEdit widget when reloading a classifier.

@jluethi jluethi linked an issue Sep 20, 2023 that may be closed by this pull request
@jluethi
Copy link
Collaborator

jluethi commented Sep 20, 2023

Thanks a lot @fdsteffen ! Looks good to me and also works in my tests.
I added a bit of extra documentation so that we remember why this picker is there. Neat that it only needs changes to the loader widget, so the main widgets aren't made more complex.

Will merge once tests pass again :)

Edit: I made tests fail with the code coverage reporter. Actually good reminder to add some basic tests to that loader class, will look into this :)

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #37 (63565a0) into main (710a801) will decrease coverage by 0.31%.
The diff coverage is 16.66%.

❗ Current head 63565a0 differs from pull request most recent head 084721e. Consider uploading reports for the commit 084721e to get more accurate results

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   82.37%   82.07%   -0.31%     
==========================================
  Files          11       11              
  Lines         749      753       +4     
==========================================
+ Hits          617      618       +1     
- Misses        132      135       +3     
Files Changed Coverage Δ
src/napari_feature_classifier/classifier_widget.py 77.88% <16.66%> (-1.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jluethi
Copy link
Collaborator

jluethi commented Sep 20, 2023

Ok, with those small tests added, I think that should be good enough coverage for now :) Can't figure out how to update the coverage report here, but now we have loading at least covered with some basic tests.

Merging now, thanks again @fdsteffen

@jluethi jluethi merged commit 1d76ab6 into fractal-napari-plugins-collection:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt LoadClassifierContainer to allow other file extensions
3 participants