Fixed build_pyramid test related to open_array_kwargs #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @m-albert ! I'll include that. I reviewed it a bit more closely now and noticed that our Zarrs here were having mixed . vs / separators. I now switched to fully / separators for the pyramid tests to avoid any issues like the ones we hit before. |
jluethi
merged commit b726b1a
into
fractal-analytics-platform:main
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized from #901 (comment) that the test I had introduced in #895 uses the
.dimension separator (not failing after adda2d3 because it just checks for file absence).One option would be to simply remove the test, alternatively this PR fixes it.
Checklist before merging
CHANGELOG.md