Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation of parameter types #560

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Improve documentation of parameter types #560

merged 1 commit into from
Oct 24, 2023

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Oct 23, 2023

Public-Facing Changes

None

Description

Addresses #519 (comment)

jtbandes
jtbandes reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think "respectively" was used correctly, but this is fine too 😛

@defunctzombie
Copy link
Contributor

FWIW, I think "respectively" was used correctly, but this is fine too 😛

Yea - I found it required more mental energy to understand when reading the spec compared to enumerating them separately.

@achim-k achim-k merged commit 00e8ca5 into main Oct 24, 2023
10 checks passed
@achim-k achim-k deleted the achim-k-patch-2 branch October 24, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes left review comments

@defunctzombie defunctzombie defunctzombie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achim-k @defunctzombie @jtbandes