Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cookie ga management + set compatibility with guzzle 5 #3

Merged
merged 3 commits into from
Jun 6, 2016

Conversation

Nightbr
Copy link
Contributor

@Nightbr Nightbr commented Jun 1, 2016

Hello,
I create a fork of your bundle and I manage to handle properly the cookie issue #1 and the take into account Guzzle 5 dependencies #2

You can find in my fork repository 2 tags (1.1.0 and 2.0.0):

  • 1.1.0 is for "theiconic/php-ga-measurement-protocol": "^1.1" with Guzzle 5
  • 2.0.0 is for "theiconic/php-ga-measurement-protocol": "^2.0" with Guzzle 6

Thank you in advance for the merge!

If you have any question don't hesitate!

@@ -14,7 +15,7 @@
],
"require": {
"php": ">=5.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be 5.4

@Nightbr
Copy link
Contributor Author

Nightbr commented Jun 6, 2016

@foaly-nr1 done! thanks

@foaly-nr1 foaly-nr1 merged commit 6f9d13c into fourlabsldn:master Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants