-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom data #20
base: develop
Are you sure you want to change the base?
Custom data #20
Conversation
Thanks for the example |
Thanks for the PR! There seems to be some extra files here. Can you rebase or branch of of develop to resubmit for merge? |
@rafibomb is that better? |
I am doing exactly the same thing for my project and planning to make a pull request. But I just gave it up after seeing this. Just one comment. I think adding .gitkeep file inside data folder is good enough. data.yml is not necessary because the data files should be created by developer. |
This should be merged. At the moment the docs do not describe this. The data property is missing by default. cc @maximilianue |
I think it is good to have the documentation in the file as it is in the project and always available as a reference. The docs are always changing and not bound to specific releases or may be too new in some cases (think about maintaining an old panini / foundation-emails-template project in the future). |
Adds custom data file by default
Closes foundation/foundation-emails#493 as the documentation update isn't necessary if this is merged
develop
was out of date with master so that is part of this as well. If that's not how this should be handled, let me know.