Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhanced pincode.txt #220

Merged
merged 5 commits into from
Aug 4, 2017
Merged

enhanced pincode.txt #220

merged 5 commits into from
Aug 4, 2017

Conversation

saurabhjn76
Copy link
Member

Fixes issue #218

Etherpad Link: http://dream.susi.ai/p/longlat

Changes: added intent in pincode.txt in knowledge

Screenshots for the change:
image

@Manveer695
Copy link
Contributor

I have no idea how to solve it but I am getting old answers:
longlat issue

Can you check it again?

@saurabhjn76
Copy link
Member Author

@Manveer695 it's running. The difference was because of pin code instead of pincode, I will add pin code in skill too. Thanks 👍
image

@Manveer695
Copy link
Contributor

@saurabhjn76 oh great!

@mariobehling
Copy link
Member

Please add examples, description and images.

@mariobehling
Copy link
Member

Ensure format is followed and image is added.

@mariobehling
Copy link
Member

Provide a proper name. Don't user Yahoo Query Language something. You don't name a skill that uses JSON "JSON Skill Something".

@saurabhjn76
Copy link
Member Author

ok 👍

@saurabhjn76 saurabhjn76 changed the title added yahoo query language skill to give longitude latitude values based on pincode and country enhanced pincode.txt Aug 4, 2017
# Returns the long lat values based on zipcode and country
tell the longitude and latitude in * with pincode *|do you know the longitude and latitude in * with pincode *|find the longitude and latitude in * with pincode *|Search the longitude and latitude in * with pincode *|What is the longitude and latitude in * with pincode *|tell the longitude and latitude in * having pincode *|do you know the longitude and latitude in * having pincode *|find the longitude and latitude in * having pincode *|Search the longitude and latitude in * having pincode *|What is the longitude and latitude in * having pincode *
!example:tell the longitude and latitude in India having pincode 160019
!console:Latitude:$latitude$ and Longitude:$longitude$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add !expect: answer expected from your example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliAyub007 done 👍 Thanks

@hpdang
Copy link
Member

hpdang commented Aug 4, 2017

Thank you!

@hpdang hpdang merged commit f28797e into fossasia:master Aug 4, 2017
@saurabhjn76 saurabhjn76 deleted the zipcodes branch August 5, 2017 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants