Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced border length questions #170

Merged
merged 2 commits into from
Jun 25, 2017
Merged

Enhanced border length questions #170

merged 2 commits into from
Jun 25, 2017

Conversation

AliAyub007
Copy link
Member

@AliAyub007 AliAyub007 commented Jun 19, 2017 •
edited
Loading

Related issue #119

Changes:
Added more possible questions to border.txt file

saurabhjn76
saurabhjn76 approved these changes Jun 19, 2017
View reviewed changes
Copy link
Member

@saurabhjn76 saurabhjn76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work 👍 , please change the word fixes in the message as there are other skills also which needs to be enhanced

mariobehling
mariobehling requested changes Jun 20, 2017
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also have things like:

  • How long is the border of ...
  • How long is the border between country a and country b?
  • What are the countries bordering country x?

@AliAyub007
Copy link
Member Author

@mariobehling Sure I will add these too.

@hpdang hpdang merged commit a96bd0e into fossasia:master Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling requested changes

@Laughing-Boy Laughing-Boy Laughing-Boy approved these changes

@dynamitechetan dynamitechetan dynamitechetan approved these changes

@saurabhjn76 saurabhjn76 saurabhjn76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AliAyub007 @mariobehling @saurabhjn76 @dynamitechetan @Laughing-Boy @hpdang