Fixed creation of double instances in memory graph activity, this fixes #627 #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Feb 19, 2020
| @@ -1,4 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Avoid making changes in unrelated files.
| @@ -145,6 +145,7 @@ private void buildInstructionDialog() { | |||
| .setPositiveButton(R.string.focus_test_msg, (dialog, which) -> { | |||
| Intent intent = new Intent(getContext(), DataLoggerActivity.class); | |||
| intent.putExtra(ProgramModeActivity.PROGRAM_FLAG_KEY, MemoryGraphParent.MEMORY_GRAPH_FLAG); | |||
| intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK|Intent.FLAG_ACTIVITY_NEW_TASK|Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED); | |||
There was a problem hiding this comment.
Reformat the code. It will add spaces in between |'s
|
@htg2704 Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[Add issue number here. Note: This will automatically closes the issue. If you do not solve the issue entirely, please change the message to e.g. "First steps for issues #IssueNumber]
Changes: [Add here what changes were made in this issue and if possible provide links.]
Screenshot/s for the changes: [Add screenshot/s of the layout where you made changes or a
*.gifcontaining a demonstration. Use<img src="paste-url-here" width=200/>to add images]Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]