Remove packageVersion from NpmPackageJson (#445)

fossas · Nov 10, 2021 · 3bf3283 · 3bf3283
1 parent 54808d4
commit 3bf3283
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,5 +1,9 @@
 # Spectrometer Changelog
 
+## v2.19.7
+
+- Resolves a regression when parsing npm `package-lock.json` files that do not contain a `version` field ([#445](https://github.com/fossas/spectrometer/pull/445))
+
 ## v2.19.6
 
 - Special cases scans with a single VSI only filter to skip other analysis strategies ([#407](https://github.com/fossas/spectrometer/pull/407))

diff --git a/src/Strategy/Node/Npm/PackageLock.hs b/src/Strategy/Node/Npm/PackageLock.hs
@@ -29,7 +29,6 @@ import Strategy.Node.PackageJson (FlatDeps (directDeps), NodePackage (pkgName),
 
 data NpmPackageJson = NpmPackageJson
   { packageName :: Text
-  , packageVersion :: Text
   , packageDependencies :: Map Text NpmDep
   }
   deriving (Eq, Ord, Show)
@@ -47,7 +46,6 @@ data NpmDep = NpmDep
 instance FromJSON NpmPackageJson where
   parseJSON = withObject "NpmPackageJson" $ \obj ->
     NpmPackageJson <$> obj .: "name"
-      <*> obj .: "version"
       <*> obj .: "dependencies"
 
 instance FromJSON NpmDep where

diff --git a/test/Node/NpmLockSpec.hs b/test/Node/NpmLockSpec.hs
@@ -13,7 +13,6 @@ mockInput :: NpmPackageJson
 mockInput =
   NpmPackageJson
     { packageName = "example"
-    , packageVersion = "1.0.0"
     , packageDependencies =
         Map.fromList
           [