Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove jemalloc #2

Merged
merged 1 commit into from
Dec 18, 2023
Merged

remove jemalloc #2

merged 1 commit into from
Dec 18, 2023

Conversation

meghfossa
Copy link
Contributor

Overview

This PR,

  • removes jemalloc from release process.
  • bumps version for release

Acceptance criteria

  • cross build --target=x86_64-unknown-linux-musl --release does not throw error during release process

Testing plan

N/A

@meghfossa meghfossa requested a review from a team as a code owner December 18, 2023 17:33
@meghfossa meghfossa requested a review from spatten December 18, 2023 17:33
jssblck
jssblck approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@jssblck jssblck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, what's the reason? just for curiosity

@meghfossa
Copy link
Contributor Author

lgtm, what's the reason? just for curiosity

I copied release.yml from broker, and I think we were using jemalloc looking from docs. I don't think we need it (CI ran into package missing error in release).

@meghfossa meghfossa merged commit 7543b3e into main Dec 18, 2023
10 checks passed
@meghfossa meghfossa deleted the feat/remove-jemalloc-for-release branch December 18, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jssblck jssblck jssblck approved these changes

@spatten spatten Awaiting requested review from spatten spatten is a code owner automatically assigned from fossas/analysis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meghfossa @jssblck