adds basic tooling #1

meghfossa · 2023-12-07T20:49:41Z

Overview

This PR,

adds basic tooling
adds release GH workflow
updates readme

Acceptance criteria

As a user,

I can create migration file

Testing plan

cargo build
cargo run -- example # should create example.yml file
cargo run -- migrate example.yml # should write migration file

src/migration/entry.rs

Cargo.toml

jssblck · 2023-12-11T19:53:31Z

Cargo.toml

+regex = "1"
+chrono = "0.4"
+indoc = "2"
+locator = { git = "https://github.com/fossas/locator-rs.git"}


Similarly, I recommend specifying version here.

Cargo.toml

README.md

src/migration/util.rs

src/migration/entry.rs

src/migration/example.rs

src/migration.rs

jssblck

LGTM after the naming comment! Rest are optional, but IMO make for more maintainable projects so are a good thing to do.

src/ingestion.rs

src/migration.rs

meghfossa added 3 commits December 7, 2023 13:48

adds basic tooling

ed598d6

remove srclib

fc5b831

update from broker to reachability-toolkit

d938da2

meghfossa commented Dec 7, 2023

View reviewed changes

src/migration/entry.rs Outdated Show resolved Hide resolved

meghfossa marked this pull request as ready for review December 7, 2023 20:55

meghfossa requested a review from a team as a code owner December 7, 2023 20:55

meghfossa requested review from JeffreyHuynh1 and jssblck and removed request for a team and JeffreyHuynh1 December 7, 2023 20:55

use locator-rs

b6620da

jssblck requested changes Dec 11, 2023

View reviewed changes

meghfossa added 3 commits December 11, 2023 15:49

address pr feedback

8b649c1

unwrap to expect

c8b5de1

fmt fix

4164ac2

meghfossa commented Dec 11, 2023

View reviewed changes

src/migration.rs Outdated Show resolved Hide resolved

meghfossa requested a review from jssblck December 11, 2023 23:04

jssblck reviewed Dec 12, 2023

View reviewed changes

src/migration.rs Outdated Show resolved Hide resolved

jssblck requested changes Dec 12, 2023

View reviewed changes

src/migration.rs Outdated Show resolved Hide resolved

use two modules and TryFrom<>

6adc7d8

meghfossa requested a review from jssblck December 12, 2023 18:17

jssblck approved these changes Dec 12, 2023

View reviewed changes

src/ingestion.rs Outdated Show resolved Hide resolved

src/ingestion.rs Outdated Show resolved Hide resolved

src/migration.rs Outdated Show resolved Hide resolved

use typedbuilder

fa086e5

meghfossa merged commit ea6ce87 into main Dec 13, 2023
10 checks passed

meghfossa deleted the feat/adds-basic-tooling branch December 13, 2023 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds basic tooling #1

adds basic tooling #1

meghfossa commented Dec 7, 2023 •

edited

Loading

jssblck Dec 11, 2023

jssblck left a comment

adds basic tooling #1

adds basic tooling #1

Conversation

meghfossa commented Dec 7, 2023 • edited Loading

Overview

Acceptance criteria

Testing plan

jssblck Dec 11, 2023

Choose a reason for hiding this comment

jssblck left a comment

Choose a reason for hiding this comment

meghfossa commented Dec 7, 2023 •

edited

Loading