-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grab bag refactor #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have questions about the ordering function, so let's chat about those and then I can re-review and approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the change to implement Ord
for the individual parts of the Locator, and the name change to Package.
Overview
Adds some stuff that would have been helpful to have when working on Sherlock, and I'm running into with Sparkle again.
StrictLocator
, which requires therevision
component.Ord
,PartialOrd
, andJSONSchema
implementations to all public types.Package
,Revision
,OrgId
).project
field topackage
field to reduce confusion between the term "project" and "package" (as in, "PackageLocator").Acceptance criteria
We can:
Testing plan
Automated tests.
Risks
Not risky.
References
Part of the Sparkle work.
Checklist