Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grafana image hash. #1470

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Update grafana image hash. #1470

merged 6 commits into from
Sep 12, 2024

Conversation

csasarak
Copy link
Contributor

@csasarak csasarak commented Sep 11, 2024

Overview

One of our unit tests broke because we were expecting the wrong digest hash. I'm really not sure what happened here since no changes we made seem to have touched this. I first noticed this with #1468 to master - it succeeded in the PR but failed when merged to master.

When I docker pull grafana/grafana:8.1.7-ubuntu I get an amd64 image which has the same hash as we were originally expecting. This is despite the fact that the test requests "arm". When I explicitly request arm with docker pull --platform=arm grafana/grafana:8.1.7-ubuntu I get an image downloaded with the correct manifest.

Testing with the redis image shows the same thing.

This implies to me that in the past we requested the arm image in our unit test but the remote server was sending the amd64 image instead and now for some reason the remote is sending the actual arm image. The difference in digest hashes are what broke our tests.

In any case, this should allow tests to pass on master when it merges.

Acceptance criteria

  • Tests and build succeed.

Testing plan

I looked at the results of CI.

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@csasarak csasarak requested a review from a team as a code owner September 11, 2024 19:12
@csasarak csasarak requested a review from zlav September 11, 2024 19:12
@csasarak
Copy link
Contributor Author

I think that maybe "arm" wasn't a recognized platform so docker may have just downloaded an image compatible with the platform it was running on. But now "arm" might be a valid value for platform which broke the tests?

Copy link
Member

@jssblck jssblck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth noting in the tests that the digest is the one represented locally, not the one we observe on the docker hub web interface. Either way though lgtm!

@csasarak csasarak merged commit cc34d94 into master Sep 12, 2024
19 checks passed
@csasarak csasarak deleted the fix-image-hash branch September 12, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants