Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
One of our unit tests broke because we were expecting the wrong digest hash. I'm really not sure what happened here since no changes we made seem to have touched this. I first noticed this with #1468 to master - it succeeded in the PR but failed when merged to master.
When I
docker pull grafana/grafana:8.1.7-ubuntu
I get anamd64
image which has the same hash as we were originally expecting. This is despite the fact that the test requests "arm". When I explicitly request arm withdocker pull --platform=arm grafana/grafana:8.1.7-ubuntu
I get an image downloaded with the correct manifest.Testing with the
redis
image shows the same thing.This implies to me that in the past we requested the arm image in our unit test but the remote server was sending the amd64 image instead and now for some reason the remote is sending the actual arm image. The difference in digest hashes are what broke our tests.
In any case, this should allow tests to pass on master when it merges.
Acceptance criteria
Testing plan
I looked at the results of CI.
Checklist
docs/
.docs/README.ms
and gave consideration to how discoverable or not my documentation is.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
AND I have updated example files used byfossa init
command. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.