Skip to content

Commit

Permalink
Remove fallbacks. It already does that.
Browse files Browse the repository at this point in the history
  • Loading branch information
csasarak committed Dec 3, 2024
1 parent 1847732 commit f3c3ba5
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/Strategy/Gomodules.hs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ getDeps project goDynamicTactic = do
mode <- ask
(graph, graphBreadth) <-
context "Gomodules" $
dynamicAnalysis <||> guardStrictMode mode fallbacks
dynamicAnalysis <||> guardStrictMode mode goDotModAnalysis
stdlib <- recover . context "Collect go standard library information" . listGoStdlibPackages $ gomodulesDir project
pure $
DependencyResults
Expand All @@ -83,8 +83,6 @@ getDeps project goDynamicTactic = do
, dependencyManifestFiles = [gomodulesGomod project]
}
where
fallbacks :: (Has Diagnostics sig m, Has Exec sig m, Has ReadFS sig m) => m (Graphing Dependency, GraphBreadth)
fallbacks = goDotModAnalysis <||> Gomod.analyzeStatic (gomodulesGomod project)
-- `go list -json -deps all` marks std lib deps with a boolean, so Strategy.Go.GoListPackages does this filtering itself.
-- I think this can be removed when `go list -json -deps all` becomes the default.
filterGraph :: Maybe [GoStdlibDep] -> Graphing Dependency -> Graphing Dependency
Expand Down

0 comments on commit f3c3ba5

Please sign in to comment.