Skip to content

Commit

Permalink
Bring back non linux arm cargo tests and diagnose checks.
Browse files Browse the repository at this point in the history
  • Loading branch information
csasarak committed Aug 29, 2024
1 parent b2a8277 commit 32ef99b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
22 changes: 16 additions & 6 deletions .github/workflows/build-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,20 @@ jobs:
# Non-Linux environments generally don't need `jemalloc`
# and in particular Windows doesn't support it.
# This purposely excludes the linux arm build.
- name: Build Rust dependencies (non-Linux)
if: ${{ ! contains(matrix.os-name, 'linux') }}
run: cargo build --release

# Run tests in release mode to reduce the need for rebuilds.
# - name: Test Rust dependencies
# run: cargo nextest run --release
- name: Test Rust dependencies
if: ${{ matrix.os-name != 'LinuxARM' }}
run: cargo nextest run --release

- name: Validate diagnose commands run on the platform
if: ${{ matrix.os != 'LinuxARM' }}
run: |
cargo run --release --bin diagnose -- walk --trace-spans none --trace-level info
- name: Ensure git ownership check does not lead to compiler error
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
Expand Down Expand Up @@ -171,10 +178,13 @@ jobs:
if: ${{ matrix.os != 'LinuxARM' }}
run: ./.github/workflows/scripts/build.sh ${{ runner.os }} ${{ matrix.project-file }}

# TODO: Got a permissions error, I'm guessing that the directory inside the image has bad perms outside of it.
# - name: Validate diagnose commands run on the platform
# run: |
# cargo run --release --bin diagnose -- walk --trace-spans none --trace-level info
# Test cabal-install
# TODO: This has apparently not been turned on for a while since no matrix.os contains 'linux'.
# When I make it function it causes an error.
# This is something I need to look into in the future.
- name: Test Cabal Install (Linux)
if: ${{ contains(matrix.os, 'linux') }}
run: cabal install --overwrite-policy=always --project=${{ matrix.project-file }} --ghc-options="-Wwarn"

# Save artifacts.
- name: Find and move binaries (Windows)
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/scripts/build-arm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,8 @@ cargo build --release

cargo test --release

# Validate that diagnose runs
cargo run --release --bin diagnose -- walk --trace-spans none --trace-level info

# Now do Haskell things
./.github/workflows/scripts/build.sh "$RUNNER_OS" "$PROJECT_FILE"

0 comments on commit 32ef99b

Please sign in to comment.