Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependency scan job #147

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Clean up dependency scan job #147

merged 1 commit into from
Nov 20, 2024

Conversation

jssblck
Copy link
Member

@jssblck jssblck commented Nov 20, 2024

Overview

Cleans up the dependency scan job to make it read a little more nicely.

@jssblck jssblck requested a review from a team as a code owner November 20, 2024 22:14
@jssblck jssblck requested a review from nficca November 20, 2024 22:14
@jssblck jssblck enabled auto-merge (squash) November 20, 2024 22:16
Comment on lines -11 to -12
# Just try to run fossa up to twice, for the case of temporary network or service issues.
- run: fossa analyze || fossa analyze
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing this hasn't been much of an issue to warrant keeping this? Seems pretty hacky anyways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't think it ever actually was an issue, I think we did it "just in case"

@jssblck jssblck merged commit 47c9c5d into main Nov 20, 2024
14 checks passed
@jssblck jssblck deleted the dependency-scan-tweak branch November 20, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants