Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat #135

Merged
merged 4 commits into from
Sep 19, 2023
Merged

reformat #135

merged 4 commits into from
Sep 19, 2023

Conversation

JeffreyHuynh1
Copy link
Contributor

Overview

Provide an overview of this change. Describe the intent of this change, and how it implements that intent.

Example: This PR accomplishes X by doing Y.

Acceptance criteria

If this PR is successful, what impact does it have on the user experience?

Example: When users do X, Y should now happen.

Testing plan

How did you validate that this PR works? What literal steps did you take when manually checking that your code works?

Example:

  1. Set up test case X.
  2. Run command Y. Make sure Z happens.

This section should list concrete steps that a reviewer can sanity check and repeat on their own machine (and provide any needed test cases).

Risks

Highlight any areas that you're unsure of, want feedback on, or want reviewers to pay particular attention to.

Example: I'm not sure I did X correctly, can reviewers please double-check that for me?

References

Add links to any referenced GitHub issues, Zendesk tickets, Jira tickets, Slack threads, etc.

Example:

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).

@JeffreyHuynh1 JeffreyHuynh1 requested a review from a team as a code owner September 18, 2023 21:32
@@ -136,7 +136,6 @@ struct ScanGitVCSReference {
}

impl ScanGitVCSReference {
/// Instantiate ScanGitVCSReference instance
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially had this comment because I made this a public function because I needed it to grab the jobID and clippy/ rustfmt wanted me to provide a comment. I'm not using it anymore so I opted to just delete the comment and have it restored back to what ti was originally

@JeffreyHuynh1 JeffreyHuynh1 merged commit 1790ef3 into main Sep 19, 2023
@JeffreyHuynh1 JeffreyHuynh1 deleted the Broker-Fix-Reformat branch September 19, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants