tinystdio: Fix vfprintf to not cap the max precision to print a hex format #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat printing using %.15a or %.15A formats give wrong results because dtox_engine handles max of 13 figures after decimal point in hex format. and it carried out that maximum precision to vfprintf function which max out the number of digits that get printed so if the format given is more than %.13a or %.13A it will still print 13 digits after the decimal place instead of just adding zeros after 13 digits which is not the correct behavior for vfprintf. After this change vfprintf handles more than 13 figures after the decimal point in hex format. Signed-off-by: Ahmed Shehab <[email protected]>
issue found by running SuperTest by Solid Sands Signed-off-by: Ahmed Shehab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printing using %.15a or %.15A formats give wrong results because dtox_engine
handles max of 13 figures after decimal point in hex format.
and it carried out that maximum precision to vfprintf function which max out the
number of digits that get printed so if the format given is more than %.13a or
%.13A it will still print 13 digits after the decimal place instead of just adding
zeros after 13 digits which is not the correct behavior for vfprintf.
After this change
vfprintf handles more than 13 figures after the decimal point in hex format.
Issue found by running SuperTest by SolidSands.