makefile: fix the root path of OPENOCD_SCRIPT_ROOT #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrodkin
requested changes
Nov 24, 2021
There was a problem hiding this comment.
Could you please add more details in the commit message?
In particular:
- What is the problem you're trying to solve and how it gets manifested (I assume you were able to reproduce it yourself).
- What was the root cause of this? In that case It guess we're talking about regression introduced by some earlier change.
- What do you do with the fix, i.e. why do you do exactly what you implement but nothing else.
I did see a reference to the issue, but think of those who'll be looking at that commit in their local git repo, what kind of information will be available for them to really digest your nice fix?
The openocd scripts root directory gets calculated improperly, OPENOCD_EXECUTABLE_ROOT is the 'bin' folder, it's in the same parent dirextory as 'script', so we need use '..' to get the parent directory first. fix issue foss-for-synopsys-dwc-arc-processors#174 Signed-off-by: Jingru Wang <[email protected]>
wangnuannuan
force-pushed
the
fix-openocd-error
branch
from
5350f18 to
34e931f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #174