-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support numeric tokens (params prefixed with v
)
#10
base: master
Are you sure you want to change the base?
Conversation
hmm, can you elabore more on this @drewfish? |
@caridy the details are in the trello card "support numeric replaces like |
@@ -200,6 +203,15 @@ | |||
return chunk; | |||
} | |||
|
|||
for (key in params) { | |||
if (params.hasOwnProperty(key)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concern about the perf implications here. Ideally, we should have a flag or something to trigger this behavior. /cc @ericf
Is this common for Dust helper libs to do with unnamed params? If not, then this seems out of the scope of what this package should support. Unnamed params seem less ideal than named params because they would suffer from the same ambiguity as boolean params (e.g., I think if this translation of argument index to argument name needs to happen, it should be inside the app code base. |
@caridy @ericf what do we want do with this one? We have many developers that use this functionality in our own helper. Example:
Final output would be:
We need to pass this into the string so that translators can format it properly. /cc @willthai |
Last I heard (March 11th) from Rajiv:
|
He was responding to an email where I suggested changing |
No description provided.