initial feedback -- DO NOT MERGE #77
Conversation
|
Amazing wrangling of a really complex problem--super impressive work here. I would say that some of the more imperative work (that is, the stuff that's hard to read because it's so complicated by its nature) could probably have benefited from being broken down into declarative functions and pieced back together in a compose function. I know that if I were maintaining this, some of the game logic would take a while for me to feel comfortable messing with. Anyhow, the code is generally very clean and creative, a pleasure to read, and would be fun for a future coder to maintain. Presentation feedback: Y’all showed a lot of team-spirit and the audience could tell that you had fun with this project. A real crowd-pleasing presentation! The only critique I can think of is that it would have been nice to have some kind of visualization for Vance’s tech talk, since the problem was so interesting, but pretty hard to follow. I would have liked to see some more concise, focused tech talks, since code in particular can be hard to follow, but considering the complexity of the work y’all did, it’s understandable that so much was hard to summarize. |
No description provided.