Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

37849678: Use ESM in yaem's eslint configuration #177

Merged
merged 2 commits into from
Jun 18, 2024
Merged

37849678: Use ESM in yaem's eslint configuration #177

merged 2 commits into from
Jun 18, 2024

Conversation

DamienCassou
Copy link
Member

@DamienCassou DamienCassou commented Jun 17, 2024 •
edited
Loading

@DamienCassou DamienCassou marked this pull request as ready for review June 17, 2024 16:00
danglotb
danglotb approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@danglotb danglotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @JohanBriglia, and @ValentinaVasile)

JohanBriglia
JohanBriglia approved these changes Jun 18, 2024
View reviewed changes
Copy link

@JohanBriglia JohanBriglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem and @ValentinaVasile)

@DamienCassou DamienCassou force-pushed the 37849678/Use_ESM_in_yaem_s_eslint_configuration branch from 9112386 to 016d8b5 Compare June 18, 2024 09:31
@DamienCassou DamienCassou merged commit a64af5c into main Jun 18, 2024
2 checks passed
@DamienCassou DamienCassou deleted the 37849678/Use_ESM_in_yaem_s_eslint_configuration branch June 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanBriglia JohanBriglia JohanBriglia approved these changes

@danglotb danglotb danglotb approved these changes

@ValentinaVasile ValentinaVasile Awaiting requested review from ValentinaVasile ValentinaVasile is a code owner

@BenjaminVanRyseghem BenjaminVanRyseghem Awaiting requested review from BenjaminVanRyseghem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DamienCassou @danglotb @JohanBriglia